fix: handle skipped audits and groups #911
Merged
+1,148
−306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🔬 testing
hanna-skryl
changed the title
hanna-skryl
force-pushed
the
fix/invalid-category-references
branch
from
8610bf6 to
884f53c
Compare
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit 4df66ef with source commit 4777a83. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories
👍 1 group improved, 👎 1 group regressed, 👍 4 audits improved, 👎 4 audits regressed, 10 audits changed without impacting score🗃️ Groups
15 other groups are unchanged. 🛡️ Audits
570 other audits are unchanged. |
hanna-skryl
force-pushed
the
fix/invalid-category-references
branch
from
1e29603 to
10e761b
Compare
matejchalk
reviewed
Jan 8, 2025
packages/plugin-lighthouse/src/lib/lighthouse-plugin.unit.test.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/lib/implementation/validate-filter-options.utils.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/lib/implementation/validate-filter-options.utils.ts
Outdated
Show resolved
Hide resolved
matejchalk
reviewed
Jan 8, 2025
github-actions
bot
added
the
📖 Project documentation
hanna-skryl
commented
Jan 10, 2025
matejchalk
reviewed
Jan 10, 2025
packages/cli/src/lib/implementation/validate-filter-options.utils.ts
Outdated
Show resolved
Hide resolved
matejchalk
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #903
This fix enhances the filtering of report results by audits and groups through the core configuration (currently implemented for the Lighthouse plugin only).
The
isSkippedproperty is introduced in thePluginConfigmetadata for audits and groups, ensuring the complete set of plugin audits and groups is retained duringCoreConfigvalidation to prevent unexpected errors. Filtering is now deferred to the filter middleware, which accurately handles skipped items by removing categories that contain only skipped or zero-weight references.